Skip to content

Fix right-panel gaps and jumps when resizing - #3599

Merged
brsbl merged 24 commits into
mainfrom
bb/investigate-drag-interaction-bugs-thr_3bp5in88fn
Sep 13, 2026
Merged

brsbl merged 24 commits into
mainfrom
bb/investigate-drag-interaction-bugs-thr_3bp5in88fn

Conversation

@brsbl

@brsbl brsbl commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The snap preview changed DOM flex independently of the panel library while both handled pointer input. Repeated drags could desynchronize panel width and open state, causing white strips, release jumps, and duplicate toggles.

What changed

  • Dragging stays within both width limits, with the panel library owning every size update.
  • Releasing the handle preserves its position without white strips or duplicate toggles.

How you verified

  • Remote CI passed, including all 15 resize regression tests.
  • Chrome for Testing 153.0.8010.36: limits, rapid reversals, viewport exit, keyboard resizing, reload, and reopening passed.
  • All 21 recorded release frames retained the divider position without a gap.

Web screenshots use the same stopped thread and two drags to maximum width: 1720 × 1040 CSS pixels, captured at 2×.

Before — merge base cf51227e1 After — head d73c0e699
Before: repeated dragging leaves a 210px white strip After: panel stays within its limit and fills the window edge

BB-Thread-ID: thr_3bp5in88fn

AGENT GENERATED

@brsbl brsbl changed the title Keep right-panel drag layout synchronized Fix right-panel gaps and jumps when resizing Sep 13, 2026
@brsbl
brsbl marked this pull request as ready for review September 13, 2026 04:12
@brsbl
brsbl merged commit 9e16411 into main Sep 13, 2026
16 checks passed
@brsbl
brsbl deleted the bb/investigate-drag-interaction-bugs-thr_3bp5in88fn branch September 13, 2026 16:38
danielbachhuber added a commit to danielbachhuber/bb that referenced this pull request Sep 15, 2026
…sjm6wmdy

- apps/app/src/components/secondary-panel/ThreadSecondaryPanel.tsx: main's
  right-panel resize fix (get-bb#3599) removed the hook's external
  handleSecondaryPanelDragging in favor of an internal handler plus a new
  required onResizeStart callback, while this branch simplified the same
  destructure by dropping the old onResizeStart-based expiry wiring (this
  PR deletes handleSecondaryPanelResizeStart and the display-mode expiry
  behavior it existed to support). Kept main's resizeHitTargetRef-based
  resize handling and supplied a no-op onResizeStart, since the only
  previous caller of that callback (expiry-on-resize) is intentionally
  removed by this PR and nothing else needs a resize-start signal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant